Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(runner): store gather timing on artifacts #13587

Merged
merged 7 commits into from
Feb 1, 2022

Conversation

adamraine
Copy link
Member

Proposal to fix the timing issues in #13569.

  • Taking a position on core(runner): independent gather and audit functions #13569 (comment) , lh:runner:gather will always reflect the time spent gathering the page, and never the time to load artifacts from disk.
  • There will always be a lh:runner:gather in artifacts.Timing
  • Sample artifacts will have unique startTime for each timing entry so they aren't deduped in Runner._getTiming:

// As entries can share a name, dedupe based on the startTime timestamp
].map(entry => /** @type {[number, PerformanceEntry]} */ ([entry.startTime, entry]));
const timingEntries = Array.from(new Map(timingEntriesKeyValues).values())

@adamraine adamraine marked this pull request as ready for review January 26, 2022 19:50
@adamraine adamraine requested a review from a team as a code owner January 26, 2022 19:50
@adamraine adamraine requested review from connorjclark and removed request for a team January 26, 2022 19:50
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup its great

@adamraine adamraine merged commit 900f948 into fr-defer-audit-runner Feb 1, 2022
@adamraine adamraine deleted the artifacts-timing branch February 1, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants