Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Don't refresh filesystem if path hasn't changed #746

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

qsniyg
Copy link
Contributor

@qsniyg qsniyg commented Jul 11, 2020

Switching between tabs with the same path will refresh the filesystem widget, even if it's not required.

I'm wondering if down the road, a better solution would be to separate the model/view, so that a cache of the filesystem can be stored for each open tab (or a maximum of n tabs), and then a single filesystem widget can then just switch between the current model that it's displaying.

Copy link
Owner

@GitSquared GitSquared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

I'm wondering if down the road, a better solution would be to separate the model/view, so that a cache of the filesystem can be stored for each open tab (or a maximum of n tabs), and then a single filesystem widget can then just switch between the current model that it's displaying.

Down the road, the entire app will probably get rewritten. Maybe if TRON 3 releases.

@GitSquared GitSquared merged commit 1b60a87 into GitSquared:master Jul 11, 2020
DongyunLee pushed a commit to 88hack/edex-ui that referenced this pull request Aug 18, 2020
@lebarde lebarde mentioned this pull request Nov 25, 2020
18 tasks
eugene2candy pushed a commit to eugene2candy/edex-ui that referenced this pull request Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants