This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Add option to configure the displayed welcome username #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitSquared
approved these changes
Jul 11, 2020
|
Leaving this kind of very-edge-case customization to be manually added to the settings file is fine. I've documented the setting in the Wiki. Thanks for the PR! |
DongyunLee
pushed a commit
to 88hack/edex-ui
that referenced
this pull request
Aug 18, 2020
eugene2candy
pushed a commit
to eugene2candy/edex-ui
that referenced
this pull request
Apr 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because who wouldn't like to see "Welcome back, John Wick"? :)
On a more serious note, I wasn't sure whether or not to add it to the initial settings file or not, because an empty string (or null) would represent an auto-detected username, but this might not make immediate sense to someone looking at the settings file (since comments aren't allowed in json).
Alternatively, I guess it could also maybe write the username in the initial settings file.