Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS intel64 build-action #5526

Closed
wants to merge 4 commits into from
Closed

Conversation

Genxster1998
Copy link
Contributor

@Genxster1998 Genxster1998 commented Nov 24, 2024

I just changed runner machine to macos-13.You can check artifacts here./~https://github.com/Genxster1998/scrcpy-old/actions/runs/12000259857
For intel machine it is working.
2024-11-25 04 39 45 github com ec1e0c3d3bbd
PS: Forgot to reflect changes in generate-checksums.sh.

@Genxster1998 Genxster1998 changed the title For MacOS Intel64 , I just changed runner machine to macos-13 Add macOS intel64 build-action Nov 24, 2024
@rom1v
Copy link
Collaborator

rom1v commented Nov 25, 2024

Thank you 👍

I added preliminary commits, in particular to add the architecture on Linux and macOS.
I reused the same build_macos.sh script to avoid duplication.

I renamed intel to x86_64. (Is it ok for you?)

Please review/test linux_macos_arch.

@Genxster1998
Copy link
Contributor Author

Thank you 👍

👍

I added preliminary commits, in particular to add the architecture on Linux and macOS. I reused the same build_macos.sh script to avoid duplication.

👍

I renamed intel to x86_64. (Is it ok for you?)

I can't agree more but they do use intel suffix sometimes, you know Apple.

Please review/test linux_macos_arch.

i just ran the app from linux_macos_arch branch , it works correctly.

rom1v added a commit to rom1v/scrcpy that referenced this pull request Nov 28, 2024
PR Genymobile#5526 <Genymobile#5526>

Co-authored-by: Genxster1998 <ck.2229.ck@gmail.com>
rom1v pushed a commit to rom1v/scrcpy that referenced this pull request Nov 28, 2024
Add actions to build a release for macOS x86_64 in addition to the
aarch64 version.

PR Genymobile#5526 <Genymobile#5526>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Nov 28, 2024

Merged into dev 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants