Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show how to convert plots from Plots.jl #37

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

blegat
Copy link
Contributor

@blegat blegat commented Aug 25, 2023

It would be simpler with JuliaPlots/Plots.jl#4809

@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for learngenie ready!

Name Link
🔨 Latest commit d73e364
🔍 Latest deploy log https://app.netlify.com/sites/learngenie/deploys/64ecb8219cf47200086b936b
😎 Deploy Preview https://deploy-preview-37--learngenie.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PGimenez
Copy link
Member

Thanks! I've added a short MWE with the switch to the plotlyjs backend. Hope the Plots.jl guys accept your PR!

@PGimenez PGimenez merged commit bdb09e7 into GenieFramework:main Aug 28, 2023
@blegat
Copy link
Contributor Author

blegat commented Aug 29, 2023

I thought Plots.plotlyjs() was not needed since we were calling plotly_traces manually but if you don't call Plots.plotlyjs() then you probably don't have things initialized, I didn't check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants