Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POAM Constraints #1178

Merged

Conversation

Gabeblis
Copy link
Contributor

Committer Notes

Purpose

This PR aims to add 6 new POAM constraints per issue #1176.

Changes

Modified dev script to handle poam model test scaffolding.
Added Constraints:

  • poam-item-has-scheduled-completion-date
  • poam-item-has-status-date
  • poam-item-has-vendor-checkin-date
  • scheduled-completion-date-type
  • status-date-type
  • vendor-dependency

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Feb 27, 2025
@Gabeblis Gabeblis requested a review from a team as a code owner February 27, 2025 15:29
@Gabeblis Gabeblis linked an issue Feb 27, 2025 that may be closed by this pull request
14 tasks
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look excellent, thanks for working through them so quickly, @Gabeblis. Can you repoint/target this branch to the following branch so we do not release these constraints into an upcoming release?

/~https://github.com/GSA/fedramp-automation/tree/feature/constraints/poam

@Gabeblis Gabeblis changed the base branch from develop to feature/constraints/poam February 28, 2025 14:26
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrgh, forgot to hit submit on this one.

@Gabeblis Gabeblis force-pushed the constraints/issue-1176 branch from 3fe2b05 to 97713c4 Compare February 28, 2025 17:00
@Gabeblis Gabeblis force-pushed the constraints/issue-1176 branch from 97713c4 to 6a97428 Compare February 28, 2025 17:10
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the crossed wires. As always, nice work and happy to park it for post-release use. 🫡

@wandmagic wandmagic merged commit 2cb668a into GSA:feature/constraints/poam Feb 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add POAM date-time status tracking constraints
3 participants