Capability to write to Serpent #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -162,7 +186,8 @@ def writeSequenceOMCPY(Seq,prefix='S'): | |||
| return line | |||
|
|
|||
| def MCNPSurface(id,Type,surf): | |||
| MCNP_def = '' | |||
| Serpent_def = '' | |||
There was a problem hiding this comment.
This change is wrong. Should be
MCNP_def = ''
There was a problem hiding this comment.
good spot!
jpcatalanUNED
approved these changes
Oct 19, 2023
|
@alexvalentine94 thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial effort at also writing Serpent input files
Some testing success for simple models but needs further tests and edge cases.
Hopefully useful for this great tool :)
Reverse reading of Serpent -> CAD in progress but will raise separate PR.