Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #233

Merged
merged 26 commits into from
Jun 17, 2024
Merged

Dev #233

merged 26 commits into from
Jun 17, 2024

Conversation

alexvalentine94
Copy link
Collaborator

If you are a first-time contributor to GEOUNED, please read our contributing guidelines:
/~https://github.com/GEOUNED-org/GEOUNED/blob/main/CONTRIBUTING.md

Description

Please include a summary of the changes and motivation for the changes

Fixes issue

Please link to any issues that this PR fixes

Checklist

  • I'm making a PR from a feature branch on my fork into GEOUNED-org/GEOUNED/dev branch
  • I have followed PEP8 style guide for Python or run a formatter such as black or ruff format on my code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

shimwell and others added 22 commits May 17, 2024 11:27
* removed two functions that are not used

* removed 2nd split plane function

* removed split_p_planes_org

* removed gen_torus_annex_u_planes_org

* removed more unused code

* returned docs to dev status

* format
* more concise install with conda-forge

* added conda badges

* corrected badge url
* renamed functions with __

* removed random commit

* Revert "removed random commit"

This reverts commit f35b217.
* moving decompose solid into class

* lower_case_enclosure_list_added_to_attributes
* moved two methods out of start

* removed unnecessary logger line
* moved two methods out of start

* removed unnecessary logger line

* calculating bb if still None

* improved comment

* private method for now
* removed os.path and os.mkdir

* format

* defined folder

* passing str to exportStep

* format

* corrected argmument name
Co-authored-by: AlvaroCubi <55387701+AlvaroCubi@users.noreply.github.com>
* moved two methods out of start

* removed unnecessary logger line

* added from json example
…194)

* moved two methods out of start

* removed unnecessary logger line

* added UCARD null to missing parts

* full step files list

* added check for ucard above 1

* Apply suggestions from code review
* testing new theme for versioning

* moved version to navbar start

* keeping gh-pages files

* docs

* removed if push

* publish dev sub dir

* added dev version

* pointing to dev repo

* added more versions

* removed comment

* updated versions

* using version match

* added version to title

* general tidy

* added github link

* corrected url

* format

* Typo fix
* moved two methods out of start

* removed unnecessary logger line

* added dev docs

* removed random commit file
… loading geometry (#205)

* moved two methods out of start

* removed unnecessary logger line

* changed cellRange to skip_solids

* improved doc string

* lowercase args pep8
* moved two methods out of start

* removed unnecessary logger line

* changes while working therough the install
* Patch for #203

* Responding to comments on #206

* Update core.py

Add missing space to call to UF.get_box()

---------

Co-authored-by: AlvaroCubi <55387701+AlvaroCubi@users.noreply.github.com>
Co-authored-by: Grammer, Kyle <grammerkb@ornl.gov>
* Patch for #203

* Responding to comments on #206

* Update core.py

Add missing space to call to UF.get_box()

* Replace all get_box calls to have options.enlargeBox, change get_box to refer only to enlargeBox instead of options.enlargeBox

---------

Co-authored-by: AlvaroCubi <55387701+AlvaroCubi@users.noreply.github.com>
Co-authored-by: Grammer, Kyle <grammerkb@ornl.gov>
* removed config ini code

* format
@shimwell
Copy link
Collaborator

just to mention this PR should not be squashed merged

shimwell and others added 4 commits June 15, 2024 13:56
* moved two methods out of start

* removed unnecessary logger line

* started CsgToCad class definition

* added class

* added cli for csgtocad method

* restructure docs

* adding csgtocad to docs

* improved csg to cad examples

* format

* corrected json path

* moved doc string to method

* corrected file path

* quotes used in dict

* removed old code
* removed old scripts

* retrigger ci
@psauvan psauvan merged commit 30f8b3a into main Jun 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants