[asmgen] generate code for stack argument access differently #6651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To save excess arguments on the stack, previously we would 1. store the argument using SW with an immediate offset basing from locals-base register. This limits the offset to 12 bits. 2. Store the offset to the first excess argument to the last ARG register so that callee can access these. This PR reverses the order. It stores the offset to the last ARG register first. Then the store of argument to the stack slot can be made without requiring large immediate offsets, basing just on the last ARG register. Fixes #6646
CodSpeed Performance ReportMerging #6651 will degrade performances by 23.99%Comparing Summary
Benchmarks breakdown
|
IGI-111
previously approved these changes
Oct 17, 2024
sdankel
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Should we add the test program from the original issue to our test suite?
Done. |
IGI-111
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To save excess arguments on the stack, previously we would
This PR reverses the order. It stores the offset to the last ARG register first. Then the store of argument to the stack slot can be made without requiring large immediate offsets, basing just on the last ARG register.
Fixes #6646