Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation cleanup and a few formatting fixes #1229

Merged
merged 1 commit into from
Oct 7, 2017

Conversation

ktiedt
Copy link
Collaborator

@ktiedt ktiedt commented Oct 6, 2017

Here you go @DreadKnight :P

@DreadKnight DreadKnight temporarily deployed to ancientbeast-pr-1229 October 6, 2017 18:53 Inactive
Copy link
Member

@DreadKnight DreadKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things that popped up.

* playerMode : Integer : Number of players in the game
* activeCreature : Creature : Current active creature object reference
* creaIdCounter : Integer : Creature ID counter used for creature creation
* creatureData : Array : Array containing all data for the creatures
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part uses tabs to nicely arrange stuff almost like in a table fashion so that's easier visible.
screenshot from 2017-10-07 07-55-32
Was it the wrong thing to do? :)

G.UI.resizeDash();

// Resizes event
// Handle resize events
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other guy recently added a bunch of s to each verb, we need to figure out the standard way of doing things regarding this matter. I'm guessing no s is the typical way to go, it kinda felt weird that way tbh :D

@DreadKnight DreadKnight merged commit 89e3ea1 into master Oct 7, 2017
@ktiedt ktiedt deleted the documentation-fixes branch October 18, 2017 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants