Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

messy log #845

Closed
DreadKnight opened this issue Feb 9, 2016 · 1 comment
Closed

messy log #845

DreadKnight opened this issue Feb 9, 2016 · 1 comment
Labels
abilities The issue is related to an unit ability or more brainstorm Still need to figure out details about this coding This issue requires some programming priority This should get fixed as soon as possible! visuals Various things that easily catch the eye

Comments

@DreadKnight
Copy link
Member

DreadKnight commented Feb 9, 2016 •
edited
Loading

messy_log

Abolished's Wild Fire trap event logs could be grouped, having a (x2) or (x3) and summing up the damage.
Similar messages should always be grouped, while the number would be showcased after as (xNumber) and the time displayed would be of the latest event in the group.
@DreadKnight DreadKnight added coding This issue requires some programming visuals Various things that easily catch the eye abilities The issue is related to an unit ability or more labels Feb 9, 2016
@DreadKnight
Copy link
Member Author

DreadKnight commented Feb 9, 2016 •
edited
Loading

The log could be improved like this:

Impaler triggered Wild Fire Trap (x3)
Impaler is hit : 33 damage taken
Abolished uses Burning Heart (x3)
Impaler lost burn mastery point (x3)

and eventually if Wild Fire is upgraded:

Abolished burn mastery increased (x3)

The grouping would be done if Impaler's move was performed sideways, stepping on multiple traps in a single move.

This grouping can also improve situation for Greater Pyre.

@DreadKnight DreadKnight added the brainstorm Still need to figure out details about this label Feb 9, 2016
@DreadKnight DreadKnight mentioned this issue Feb 10, 2016
Closed
@DreadKnight DreadKnight added priority This should get fixed as soon as possible! and removed brainstorm Still need to figure out details about this labels Feb 10, 2016
@DreadKnight DreadKnight added the brainstorm Still need to figure out details about this label Sep 5, 2016
marcel-odya added a commit to marcel-odya/AncientBeast that referenced this issue Apr 30, 2018
@marcel-odya
Reworked log messages storing and displaying.
d928b84 
The mesages are now stored as an array of objects.
The same messages now stack.

Resolves: FreezingMoon#845
@marcel-odya marcel-odya mentioned this issue Apr 30, 2018
Merged
DreadKnight added a commit that referenced this issue Apr 30, 2018
@DreadKnight
Merge pull request #1341 from marcel-odya/master
e6280e3 
Fixed #845, fixed #1320
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
@marcel-odya
Reworked log messages storing and displaying.
88bb963 
The mesages are now stored as an array of objects.
The same messages now stack.

Resolves: FreezingMoon#845
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this issue Apr 20, 2023
@DreadKnight
Merge pull request FreezingMoon#1341 from marcel-odya/master
d0799c2 
Fixed FreezingMoon#845, fixed FreezingMoon#1320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
abilities The issue is related to an unit ability or more brainstorm Still need to figure out details about this coding This issue requires some programming priority This should get fixed as soon as possible! visuals Various things that easily catch the eye
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DreadKnight