Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

game logs should be hashes #1262

Closed
DreadKnight opened this issue Oct 15, 2017 · 0 comments
Closed

game logs should be hashes #1262

DreadKnight opened this issue Oct 15, 2017 · 0 comments
Assignees
@ktiedt
Labels
coding This issue requires some programming pipeline Affects how the project is being developed priority This should get fixed as soon as possible!
Milestone
0.4 - Bounty Hunter

Comments

@DreadKnight
Copy link
Member

DreadKnight commented Oct 15, 2017 •
edited
Loading

G.gamelog.get() function should provide the log as a hash because the outcome is really complicated to copy since it now includes the match settings as well, while G.gamelog.play() should be able to read it.

Ideally all hashes should start with game initials and version number, for example AB-0.3-JK5SsaAH.....
@DreadKnight DreadKnight added coding This issue requires some programming Hacktoberfest pipeline Affects how the project is being developed priority This should get fixed as soon as possible! labels Oct 15, 2017
@DreadKnight DreadKnight added this to the 0.4 - Bounty Hunter milestone Oct 15, 2017
This was referenced Oct 15, 2017
Closed
Closed
@ktiedt ktiedt self-assigned this Oct 15, 2017
ktiedt added a commit that referenced this issue Oct 15, 2017
@ktiedt
Fixes #1272 - relies on #1262 being merged first to work
ef2a04b
@ktiedt ktiedt mentioned this issue Oct 15, 2017
Merged
DreadKnight added a commit that referenced this issue Oct 15, 2017
@DreadKnight
Merge pull request #1268 from FreezingMoon/AB-1262
0988c8a 
Fixes #1262 - Added support for hashes and made it the default output…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktiedt ktiedt

Labels
coding This issue requires some programming pipeline Affects how the project is being developed priority This should get fixed as soon as possible!
Projects
None yet
Milestone
0.4 - Bounty Hunter
Development

No branches or pull requests
2 participants
@ktiedt @DreadKnight