276 table names are now validated to prevent sql injection #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… names lead to an exception
ratara
changed the title
…not_injection_safe
|
maybe we should replace some caracters rather then dont accept them! ; can also be injected as %3B... so they should be disallowed as well! |
I can not recommend to replace characters because this leads to table names that are wrong and unexpected. |
|
I am really not en expert on that but OK.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, I googled a lot because I thought this is no new problem. I found a library called psycopg2 that solves the problem for postgresql. I think this library would work here but there was to much overhead to integrate this library.
I decided to solve the problem with a self-written method to validate table names.
Please take a look because it felt too easy. Maybe I forgot major problems here.
See issue: #276