Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one error in continuation point calculation. #1131

Merged

Conversation

alexander-travov
Copy link
Contributor

I believe there is an off-by-one error in calculation of continuation point timestamp.

@alexander-travov
Copy link
Contributor Author

For example I have a var on server with history of values [0, 1, 2, 3, 4, 5].
When I read history of that variable in portions of maxlen=3 with the use of continuation point, I get: [0, 1, 2], [4, 5]. The value 3 is never returned.

With the fix I get: [0, 1, 2], [3, 4, 5] as expected.

@alexander-travov
Copy link
Contributor Author

Same error in FreeOpcUa/python-opcua#1494

@oroulet oroulet merged commit e680d7e into FreeOpcUa:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants