Respect DataChangeTrigger in server #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good and does not seem to break anything. jsut waiting a bit in case someone finds something |
|
I wish I had time to write proper tests for it, but we have a deadline coming up and team lead won't let me spend any more time on it. I have tested setting the DataChangeTrigger to both StatusValue and StatusValueTimestamp, and leaving it unset, using our client and test code. Everything looks like it's working, but I'm far from an OpcUa expert so I'm a little worried about breaking something that I don't know about. I hope your existing tests have good coverage :) I might be able to return to this and write those tests in a couple of weeks, so it doesn't break in the future, I hope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves DataChange filtering from address_space to monitored_item_service, and uses the configured DataChangeTrigger instead of always detecting changes in status/value.
Solves #1098