add feat: subscription.py optional param for sampling_interval #1087
Conversation
…easHeine/opcua-asyncio into client-api-samplinginterval
|
@oroulet tested against a "Unified Automation Cpp Server"! |
| queuesize: int = 0, | ||
| monitoring=ua.MonitoringMode.Reporting, | ||
| sampling_interval: ua.Duration = 0.0 | ||
| ) -> Union[int, List[Union[int, ua.StatusCode]]]: |
There was a problem hiding this comment.
ideally we should pass nodes AND the entire MonitoredItemCreateRequest so people can add whatever they want. but that breaks the API....
There was a problem hiding this comment.
for that we have "create_monitored_items"
async def create_monitored_items(self, monitored_items: List[ua.MonitoredItemCreateRequest]) -> List[Union[int, ua.StatusCode]]:
There was a problem hiding this comment.
but create_monitored_items is hard to use, it does not any handler or anything, so you need to catch events by hand (I do not even remember how tot do that)
Anyway. let's do it the way you propose for now
|
your PR is so hard to read because you have mixed up many formatting changes and typing with real code changes... |
No description provided.