Create CONTRIBUTING.md #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes most of the common errors that cause eslint to fail.
Added syntax highlighting
Added sample eslint pre-commit hook
|
@phavekes, thoughts? |
|
I would prefer to move the linting stuff to a github action, instead of manual instructions. |
|
They've been a github action for about 2 weeks now. Either way, those are worded as "highly suggested". Before you bring it up, almost all of my lint fails are from merge conflicts. :D |
|
Now that I think about it, I'm not sure if you can see the actions. I get nasty emails when a run fails. |
phavekes
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes most of the common errors that cause eslint to fail.