Allowed the generated values statement to optionally be static. Fixes #415

[bramp]

What does this change?

Allowed the generated values statement to optionally be static. For flat listings, each asset is static but the values property is not, making it inaccessible. Now when generating flat listings, values is static like all the other assets.

Fixes #415 🎯

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests (melos run unit:test)
  • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)

[codecov]

Codecov Report

Merging #435 (d1569e9) into main (32f974e) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d1569e9 differs from pull request most recent head 1e10f70. Consider uploading reports for the commit 1e10f70 to get more accurate results

@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          20       20           
  Lines         691      691           
=======================================
  Hits          679      679           
  Misses         12       12           

Files	Coverage Δ
packages/core/lib/generators/assets_generator.dart	98.08% <100.00%> (ø)

[AlexV525]

Could we add a unit test for the fix? Even though the coverage hasn't been changed, it actually did.

[bramp]

The fix is already covered in existing unit tests. Both assets_camel_case.gen.dart and assets_snake_case.gen.dart were modified to check the correct behaviour with flat style. Existing dot style does not use static, and their tests continue to work.

So I do believe it is tested (both with and without static), so I would be unsure what test to add.

[AlexV525]

The fix is already covered in existing unit tests. Both assets_camel_case.gen.dart and assets_snake_case.gen.dart were modified to check the correct behaviour with flat style. Existing dot style does not use static, and their tests continue to work.

Appreciate your explanation!

[AlexV525]

LGTM. I'm not so familiar with versioning so I guess we can add CHANGELOG entries later.