fix: Correct logic error in tool input assignment for ChatflowTool #3903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code incorrectly assigned `toolInput` to an empty string when `customInput` was non-empty. Corrected the logic to ensure that `toolInput` is assigned `customInput` when `useQuestionFromChat` is false and `customInput` is non-empty.
|
Thank you as well! I'm thrilled to have made my first contribution to an open source project. |
JJK801
pushed a commit
to JJK801/Flowise
that referenced
this pull request
Feb 3, 2025
…lowiseAI#3903) The previous code incorrectly assigned `toolInput` to an empty string when `customInput` was non-empty. Corrected the logic to ensure that `toolInput` is assigned `customInput` when `useQuestionFromChat` is false and `customInput` is non-empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the description of
customInputfor additional parameters ofChatflowTool, leaving it empty allows the LLM to decide the tool's input. Therefore, ifcustomInputis not an empty string, it should be passed to the chatflow.The previous code incorrectly assigned
toolInputto an empty string whencustomInputwas non-empty. This has been corrected to ensure thattoolInputis assignedcustomInputwhenuseQuestionFromChatis false andcustomInputis non-empty.