Bump FirelySdkVersion from 5.7.0 to 5.8.1 #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](/~https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps `FirelySdkVersion` from 5.7.0 to 5.8.0. Updates `Hl7.Fhir.Base` from 5.7.0 to 5.8.0 - [Release notes](/~https://github.com/FirelyTeam/firely-net-sdk/releases) - [Commits](FirelyTeam/firely-net-sdk@v5.7.0...v5.8.0) Updates `Hl7.Fhir.STU3` from 5.7.0 to 5.8.0 - [Release notes](/~https://github.com/FirelyTeam/firely-net-sdk/releases) - [Commits](FirelyTeam/firely-net-sdk@v5.7.0...v5.8.0) Updates `Hl7.Fhir.Conformance` from 5.7.0 to 5.8.0 - [Release notes](/~https://github.com/FirelyTeam/firely-net-sdk/releases) - [Commits](FirelyTeam/firely-net-sdk@v5.7.0...v5.8.0) Updates `Hl7.Fhir.R4` from 5.7.0 to 5.8.0 - [Release notes](/~https://github.com/FirelyTeam/firely-net-sdk/releases) - [Commits](FirelyTeam/firely-net-sdk@v5.7.0...v5.8.0) Updates `Hl7.Fhir.R4B` from 5.7.0 to 5.8.0 - [Release notes](/~https://github.com/FirelyTeam/firely-net-sdk/releases) - [Commits](FirelyTeam/firely-net-sdk@v5.7.0...v5.8.0) Updates `Hl7.Fhir.R5` from 5.7.0 to 5.8.0 - [Release notes](/~https://github.com/FirelyTeam/firely-net-sdk/releases) - [Commits](FirelyTeam/firely-net-sdk@v5.7.0...v5.8.0) Updates `Hl7.Fhir.Specification.Data.R4` from 5.7.0 to 5.8.0 - [Release notes](/~https://github.com/FirelyTeam/firely-net-sdk/releases) - [Commits](FirelyTeam/firely-net-sdk@v5.7.0...v5.8.0) Updates `Hl7.Fhir.Specification.Data.R4B` from 5.7.0 to 5.8.0 - [Release notes](/~https://github.com/FirelyTeam/firely-net-sdk/releases) - [Commits](FirelyTeam/firely-net-sdk@v5.7.0...v5.8.0) Updates `Hl7.Fhir.Specification.Data.R5` from 5.7.0 to 5.8.0 - [Release notes](/~https://github.com/FirelyTeam/firely-net-sdk/releases) - [Commits](FirelyTeam/firely-net-sdk@v5.7.0...v5.8.0) Updates `Hl7.Fhir.Specification.Data.STU3` from 5.7.0 to 5.8.0 - [Release notes](/~https://github.com/FirelyTeam/firely-net-sdk/releases) - [Commits](FirelyTeam/firely-net-sdk@v5.7.0...v5.8.0) --- updated-dependencies: - dependency-name: Hl7.Fhir.Base dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Hl7.Fhir.STU3 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Hl7.Fhir.Conformance dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Hl7.Fhir.R4 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Hl7.Fhir.R4B dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Hl7.Fhir.R5 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Hl7.Fhir.Specification.Data.R4 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Hl7.Fhir.Specification.Data.R4B dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Hl7.Fhir.Specification.Data.R5 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Hl7.Fhir.Specification.Data.STU3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
ewoutkramer
requested changes
Apr 29, 2024
| @@ -56,7 +56,7 @@ ResultReport IValidatable.Validate(IScopedNode input, ValidationSettings _, Vali | |||
| return ResultReport.SUCCESS; | |||
|
|
|||
| static string displayValue(ITypedElement te) => | |||
| te.Children().Any() ? te.ToJson() : te.Value.ToString()!; | |||
| te.Children().Any() ? te.ToJson() : te.Value?.ToString()!; | |||
There was a problem hiding this comment.
Isn't te.Value?.ToString()! the same as te.Value!.ToString() (but the latter is more clear?).
There was a problem hiding this comment.
te.Value!.ToString() can also return null
| @@ -58,7 +58,7 @@ ResultReport IValidatable.Validate(IScopedNode input, ValidationSettings _, Vali | |||
| return result; | |||
|
|
|||
| static string displayValue(ITypedElement te) => | |||
| te.Children().Any() ? te.ToJson() : te.Value.ToString()!; | |||
| te.Children().Any() ? te.ToJson() : te.Value?.ToString()!; | |||
There was a problem hiding this comment.
Isn't te.Value?.ToString()! the same as te.Value!.ToString() (but the latter is more clear?).
There was a problem hiding this comment.
te.Value!.ToString() can also return null
mmsmits
changed the title
ewoutkramer
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps
FirelySdkVersionfrom 5.7.0 to 5.8.0.Updates
Hl7.Fhir.Basefrom 5.7.0 to 5.8.0Release notes
Sourced from Hl7.Fhir.Base's releases.
Commits
6f3a2b8Create release noteseb16233bumped version to 5.8.095ce7c1Merge pull request #2771 from FirelyTeam/feature/improved-binary-supportd269b74Merge branch 'develop' into feature/improved-binary-supportca7c44dMerge pull request #2767 from FirelyTeam/feature/package-validationb359ce6automatically generate new suppression file for dotnet packe6bc218Merge branch 'develop' into feature/package-validation4c19873it broke, it should work again nowbbf4680PR requested changesc8d03eaMerge pull request #2773 from FirelyTeam/bugfix/update-core-package-nameUpdates
Hl7.Fhir.STU3from 5.7.0 to 5.8.0Release notes
Sourced from Hl7.Fhir.STU3's releases.
Commits
6f3a2b8Create release noteseb16233bumped version to 5.8.095ce7c1Merge pull request #2771 from FirelyTeam/feature/improved-binary-supportd269b74Merge branch 'develop' into feature/improved-binary-supportca7c44dMerge pull request #2767 from FirelyTeam/feature/package-validationb359ce6automatically generate new suppression file for dotnet packe6bc218Merge branch 'develop' into feature/package-validation4c19873it broke, it should work again nowbbf4680PR requested changesc8d03eaMerge pull request #2773 from FirelyTeam/bugfix/update-core-package-nameUpdates
Hl7.Fhir.Conformancefrom 5.7.0 to 5.8.0Release notes
Sourced from Hl7.Fhir.Conformance's releases.
Commits
6f3a2b8Create release noteseb16233bumped version to 5.8.095ce7c1Merge pull request #2771 from FirelyTeam/feature/improved-binary-supportd269b74Merge branch 'develop' into feature/improved-binary-supportca7c44dMerge pull request #2767 from FirelyTeam/feature/package-validationb359ce6automatically generate new suppression file for dotnet packe6bc218Merge branch 'develop' into feature/package-validation4c19873it broke, it should work again nowbbf4680PR requested changesc8d03eaMerge pull request #2773 from FirelyTeam/bugfix/update-core-package-nameUpdates
Hl7.Fhir.R4from 5.7.0 to 5.8.0Release notes
Sourced from Hl7.Fhir.R4's releases.
Commits
6f3a2b8Create release noteseb16233bumped version to 5.8.095ce7c1Merge pull request #2771 from FirelyTeam/feature/improved-binary-supportd269b74Merge branch 'develop' into feature/improved-binary-supportca7c44dMerge pull request #2767 from FirelyTeam/feature/package-validationb359ce6automatically generate new suppression file for dotnet packe6bc218Merge branch 'develop' into feature/package-validation4c19873it broke, it should work again nowbbf4680PR requested changesc8d03eaMerge pull request #2773 from FirelyTeam/bugfix/update-core-package-nameUpdates
Hl7.Fhir.R4Bfrom 5.7.0 to 5.8.0Release notes
Sourced from Hl7.Fhir.R4B's releases.
Commits
6f3a2b8Create release noteseb16233bumped version to 5.8.095ce7c1Merge pull request #2771 from FirelyTeam/feature/improved-binary-supportd269b74Merge branch 'develop' into feature/improved-binary-supportca7c44dMerge pull request #2767 from FirelyTeam/feature/package-validationb359ce6automatically generate new suppression file for dotnet packe6bc218Merge branch 'develop' into feature/package-validation4c19873it broke, it should work again nowbbf4680PR requested changesc8d03eaMerge pull request #2773 from FirelyTeam/bugfix/update-core-package-nameUpdates
Hl7.Fhir.R5from 5.7.0 to 5.8.0Release notes
Sourced from Hl7.Fhir.R5's releases.
Commits
6f3a2b8Create release noteseb16233bumped version to 5.8.095ce7c1Merge pull request #2771 from FirelyTeam/feature/improved-binary-supportd269b74Merge branch 'develop' into feature/improved-binary-supportca7c44dMerge pull request #2767 from FirelyTeam/feature/package-validationb359ce6automatically generate new suppression file for dotnet packe6bc218Merge branch 'develop' into feature/package-validation4c19873it broke, it should work again nowbbf4680PR requested changesc8d03eaMerge pull request #2773 from FirelyTeam/bugfix/update-core-package-nameUpdates
Hl7.Fhir.Specification.Data.R4from 5.7.0 to 5.8.0Release notes
Sourced from Hl7.Fhir.Specification.Data.R4's releases.
Commits
6f3a2b8Create release noteseb16233bumped version to 5.8.095ce7c1Merge pull request #2771 from FirelyTeam/feature/improved-binary-supportd269b74Merge branch 'develop' into feature/improved-binary-supportca7c44dMerge pull request #2767 from FirelyTeam/feature/package-validationb359ce6automatically generate new suppression file for dotnet packe6bc218Merge branch 'develop' into feature/package-validation4c19873it broke, it should work again nowbbf4680PR requested changesc8d03eaMerge pull request #2773 from FirelyTeam/bugfix/update-core-package-nameUpdates
Hl7.Fhir.Specification.Data.R4Bfrom 5.7.0 to 5.8.0Release notes
Sourced from Hl7.Fhir.Specification.Data.R4B's releases.
Commits
6f3a2b8Create release noteseb16233bumped version to 5.8.095ce7c1Merge pull request #2771 from FirelyTeam/feature/improved-binary-supportd269b74Merge branch 'develop' into feature/improved-binary-supportca7c44dMerge pull request #2767 from FirelyTeam/feature/package-validationb359ce6automatically generate new suppression file for dotnet packe6bc218Merge branch 'develop' into feature/package-validation4c19873it broke, it should work again nowbbf4680PR requested changesc8d03eaMerge pull request #2773 from FirelyTeam/bugfix/update-core-package-nameUpdates
Hl7.Fhir.Specification.Data.R5from 5.7.0 to 5.8.0Release notes
Sourced from Hl7.Fhir.Specification.Data.R5's releases.
Commits
6f3a2b8Create release noteseb16233bumped version to 5.8.095ce7c1Merge pull request #2771 from FirelyTeam/feature/improved-binary-supportd269b74Merge branch 'develop' into feature/improved-binary-supportca7c44dMerge pull request #2767 from FirelyTeam/feature/package-validationb359ce6automatically generate new suppression file for dotnet packe6bc218Merge branch 'develop' into feature/package-validation4c19873it broke, it should work again nowbbf4680PR requested changesc8d03eaMerge pull request #2773 from FirelyTeam/bugfix/update-core-package-nameUpdates
Hl7.Fhir.Specification.Data.STU3from 5.7.0 to 5.8.0Release notes
Sourced from Hl7.Fhir.Specification.Data.STU3's releases.