Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test that simulates the validation done by the Validation Demo. #236

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

ewoutkramer
Copy link
Member

Weirdly enough, I couldn't reproduce it - but I cannot reproduce it in the demo anymore either.

Well, at least we'll have this test at hand if we ever have such bugs again!

@ewoutkramer ewoutkramer requested review from marcovisserFurore and removed request for marcovisserFurore December 18, 2023 16:16
@ewoutkramer ewoutkramer marked this pull request as draft December 18, 2023 16:17
@marcovisserFurore
Copy link
Member

Is there a reason that this PR is still in draft?

@ewoutkramer
Copy link
Member Author

Yes, I decided that I also want to add STU3 tests, but I could not get that done today.

@ewoutkramer ewoutkramer marked this pull request as ready for review December 19, 2023 12:06
@ewoutkramer ewoutkramer merged commit b583165 into develop Dec 19, 2023
2 checks passed
@ewoutkramer ewoutkramer deleted the feature/235-invalid-profiles-are-ignored branch December 19, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants