Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback to default service account when file is not provided #49

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

elmarti
Copy link
Contributor

@elmarti elmarti commented Feb 15, 2021

This PR allows the firebase-import package to use the default service account whilst executing in GCP environments.

This removes the need for manually authenticating the CLI and retains the original behaviour

Original Behaviour

  • No service account provided - Internal Firebase error (see below)
  • Service Account provided - CLI executes correctly

New Behaviour

  • No service account provided - Fallback to default service account.
  • Service account provided - CLI uses provided service account

Internal Firebase Error
Screenshot 2021-02-15 at 12 46 41

@elmarti
Copy link
Contributor Author

elmarti commented Feb 15, 2021

Closes #47

@samtstern
Copy link
Contributor

@elmarti LGTM thank you for the contribution!

@samtstern samtstern merged commit ad98a5a into FirebaseExtended:master Feb 15, 2021
@elmarti
Copy link
Contributor Author

elmarti commented Feb 16, 2021

@samtstern thanks for the speedy response

@elmarti
Copy link
Contributor Author

elmarti commented Feb 18, 2021

@samtstern when will this be available via npm?

@samtstern
Copy link
Contributor

@elmarti I've never released this repo before (and it's been a while since anyone has) let me see if I can figure it out.

@samtstern
Copy link
Contributor

@elmarti
Copy link
Contributor Author

elmarti commented Feb 25, 2021

@samtstern Great, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants