Fix live apps #258
Merged
Fix live apps #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2025 15:07
in line with REPL.TerminalMenus
in line with REPL.TerminalMenus
|
Looks good - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, we cannot get into raw mode using the patch in eaf337c. This meant live apps are basically broken.
Looking at JuliaLang/julia@5023ee2 , all instances of
terminalwere replaced with a getter (in their case,default_terminal()). We basically do the same thing here, with a static check to see ifdefault_terminal()exists, and if not returnsREPL.TerminalMenus.terminal. This is mainly for backwards compatibility, in line eaf337c.I have no idea why the getter function works and the constant does not, maybe someone can explain this to me.
Also, I've changed from debug to warning level if we cant get into raw mode.
Working locally on Windows & WSL, using julia 1.10.7, 1.11.2, 1.12.0.
This should fix #252 #253