Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0 roadmap #174

Merged
merged 11 commits into from
Feb 6, 2023
Merged

v2.0 roadmap #174

merged 11 commits into from
Feb 6, 2023

Conversation

FedeClaudi
Copy link
Owner

@FedeClaudi FedeClaudi commented Dec 6, 2022

TODO

  • docs & tests
  • fix tests on julia nightly

v2.0 will feature:

Small fixes/changes:

  • style when reshaping text across multiple lines (fix_markup_across_lines #188)
  • logging set size of each column based on largest item
  • hLine should not leave a style aftermath
  • Table should have options to avoid printing the whole thing (select columns, how many rows...)
  • stacktrace shouldn hide main
  • logging: trimmed message without ellipsis
  • logging some weird spaces in long messages and narrow console
  • arrays repr on narrow console with flots
  • logging ltrim_str not defined
  • error msg not showing up within progress bar
  • dict repr messed up for large values and termshow for structs
  • address: Term's stacktrace is quite (perhaps too) wasteful of terminal real estate. #197

@FedeClaudi FedeClaudi added this to the v2.0 milestone Dec 6, 2022
This was linked to issues Dec 6, 2022
@FedeClaudi
Copy link
Owner Author

Decided to leave the implementation of live renderables to a future release and focus on fixing existing issues.

@FedeClaudi
Copy link
Owner Author

Decided not to change the Tree API as the AbstractTrees.jl doesn't seem to offer a complete way to construct and handle tree-like structures

* CompatHelper: add new compat entry for WordTokenizers at version 0.5, (keep existing compat) (#171)

Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>

* Stack traces (#179)

* styling

* now excludes other installed packages + fmt and tests

* small improvements ot hidden frames

* format and docs

* small fixes

* fmt

* kwarg func call fmt

* show each error line code

* covergage

* stacktrace formatting

* traces rendering improvements

* test fix

* new text reshaping function from chatgpt

* fixed tests

* cleanup

* cleanup

* bump

* bump

* bump

* prompt init

* small fixes to repr and error

* fixed small repr bugs

* removed deps

* wip errors

* method error kwargs call

* parsed kwargs calls in stackrace

* fixes

* method error edge cases

* bump

* bump

* bump

* fixed textlen bug for orphaned tags

* Update Project.toml

* Update Project.toml

* errors with no backtrace are now shown

* logger doesn't cut msgs

* CI fix

* error msg panel now always shows

* reworked logs rendering code

* msg reshaping

* refactored stacktrace code + further logs improvements

* fixed bug with markdown rendering

* Link renderable development (#180)

* bump

* bump

* working on making Link work

* functional link?

* fixing them errors

* fixed behavior of hidden frames in stacktrace and docs

* fixed bugs

* bugs fixed and more test

* bugfix

* tests fix

* tests fixing

* tests fix

* tests fix

* Fix #181 (#182)

* small fixes

* bump

* `Prompt` (#175)

* prompt init

* small fixes to repr and error

* fixed small repr bugs

* removed deps

* wip errors

* bump

* bump

* bump

* bump

* prompt wip

* bump

* prompt almost finished

* added tests and docs for prompt

* bump

* coverage and CI

* docs fix

* Update _error_messages.jl

* Annotations (#185)

* init

* more extensive precompilation

* small fixes for error IO

* 204 method invalidation at startup ops

* bump

* working on annotation

* added style

* bump

* disabled precompilation

* new code reshaping function

* new annotation system

* tests for annotations passing

* fmt

* more tests

* bump

* bump

* ci fix

* bump

Co-authored-by: Federico Claudi <federicoclaudi@imac.mynetworksettings.com>

* Create Invalidations.yml

* Create unused_dependencies.yml

* Update Invalidations.yml

* Update Invalidations.yml

* Update CI.yml

* Update CI.yml

* Coverage - adding more tests (#186)

* increasing test coverage

* fixed bug with markup tags including newline

* test coverage

* bump

* bump

* bump

* bump

* bump

* CI fix

* CI fix

* CI fix

* CI fix

* bump

* Update CI.yml

* bump

* refactored tree

* CI fix

* docs

* Update unused_dependencies.yml

* ci fix

* Update Invalidations.yml

* removed fillin(segments)

* Update CI.yml

* fmt

* bump

* removed error message functionality, using base

* bump

* fix_markup_across_lines (#188)

* fix_markup_across_lines

* tests passing

* fixed small things

* bump

* wip for fix_ansi_across_lines

* fixed nested style tags

* reshaping with ANSI and markup works well

* fmt

* bump

* bump

* bump

* removed unused funcs

* docstring

* small fixes

* bump

* Update CI.yml

* Working on pre-compilation (#173)

* init

* more extensive precompilation

* small fixes for error IO

* 204 method invalidation at startup ops

* bump

* cleaned up precompilation

* removed deps

* bump

Co-authored-by: Federico Claudi <federicoclaudi@imac.mynetworksettings.com>

* CompatHelper: add new compat entry for AbstractTrees at version 0.4, (keep existing compat) (#189)

Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>

* bump

* no stdout in precomp (#191)

* no stdout in precomp

* ignore precompilation code in coverage

* finished re-factoring tree

* CI fix

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
Co-authored-by: Rémi Vezy <VEZY@users.noreply.github.com>
Co-authored-by: Federico Claudi <federicoclaudi@imac.mynetworksettings.com>
@FedeClaudi
Copy link
Owner Author

Merged the new tree API - using AbstractTrees after all

FedeClaudi and others added 9 commits February 5, 2023 10:21
* Live first push

* bump

* bump

* pager almost ready

* pager ready

* making progress with menu

* making progress with menu

* hacky but working

* reduced flicker

* progress on making progress a Live

* redirect tsdout

* bump

* test

* introspection fmt + error fmt

* bump

* bump

* CompatHelper: add new compat entry for WordTokenizers at version 0.5, (keep existing compat) (#171)

Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>

* Stack traces (#179)

* styling

* now excludes other installed packages + fmt and tests

* small improvements ot hidden frames

* format and docs

* small fixes

* fmt

* kwarg func call fmt

* show each error line code

* covergage

* stacktrace formatting

* traces rendering improvements

* test fix

* new text reshaping function from chatgpt

* fixed tests

* cleanup

* cleanup

* bump

* bump

* bump

* prompt init

* small fixes to repr and error

* fixed small repr bugs

* removed deps

* wip errors

* method error kwargs call

* parsed kwargs calls in stackrace

* fixes

* method error edge cases

* bump

* bump

* bump

* fixed textlen bug for orphaned tags

* Update Project.toml

* Update Project.toml

* errors with no backtrace are now shown

* logger doesn't cut msgs

* CI fix

* error msg panel now always shows

* reworked logs rendering code

* msg reshaping

* refactored stacktrace code + further logs improvements

* fixed bug with markdown rendering

* Link renderable development (#180)

* bump

* bump

* working on making Link work

* functional link?

* fixing them errors

* fixed behavior of hidden frames in stacktrace and docs

* fixed bugs

* bugs fixed and more test

* bugfix

* tests fix

* tests fixing

* tests fix

* tests fix

* Fix #181 (#182)

* small fixes

* bump

* `Prompt` (#175)

* prompt init

* small fixes to repr and error

* fixed small repr bugs

* removed deps

* wip errors

* bump

* bump

* bump

* bump

* prompt wip

* bump

* prompt almost finished

* added tests and docs for prompt

* bump

* coverage and CI

* docs fix

* Update _error_messages.jl

* Annotations (#185)

* init

* more extensive precompilation

* small fixes for error IO

* 204 method invalidation at startup ops

* bump

* working on annotation

* added style

* bump

* disabled precompilation

* new code reshaping function

* new annotation system

* tests for annotations passing

* fmt

* more tests

* bump

* bump

* ci fix

* bump

Co-authored-by: Federico Claudi <federicoclaudi@imac.mynetworksettings.com>

* Create Invalidations.yml

* Create unused_dependencies.yml

* Update Invalidations.yml

* Update Invalidations.yml

* Update CI.yml

* Update CI.yml

* Coverage - adding more tests (#186)

* increasing test coverage

* fixed bug with markup tags including newline

* test coverage

* bump

* bump

* bump

* bump

* bump

* CI fix

* CI fix

* CI fix

* CI fix

* bump

* Update CI.yml

* bump

* refactored tree

* CI fix

* docs

* Update unused_dependencies.yml

* ci fix

* Update Invalidations.yml

* removed fillin(segments)

* Update CI.yml

* fmt

* bump

* removed error message functionality, using base

* bump

* fix_markup_across_lines (#188)

* fix_markup_across_lines

* tests passing

* fixed small things

* bump

* wip for fix_ansi_across_lines

* fixed nested style tags

* reshaping with ANSI and markup works well

* fmt

* bump

* bump

* bump

* removed unused funcs

* docstring

* small fixes

* bump

* Update CI.yml

* Working on pre-compilation (#173)

* init

* more extensive precompilation

* small fixes for error IO

* 204 method invalidation at startup ops

* bump

* cleaned up precompilation

* removed deps

* bump

Co-authored-by: Federico Claudi <federicoclaudi@imac.mynetworksettings.com>

* CompatHelper: add new compat entry for AbstractTrees at version 0.4, (keep existing compat) (#189)

Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>

* bump

* restored to old LiveInternals

* small improvements

* simple menu

* working on help message

* working on help

* added multi select menu

* bump

* help tooltip working

* small fixes

* pager with liner numbers and scrollbar

* tab viewer refactor

* improved key controls

* refactor

* more widgets and improvements

* tabviewer improvemens

* fixed scrollbar

* fixed introspection

* compositor accepts fractional values

* added apply_style to ren and removed extra style resets from boxes and panels

* removed apply style for renderables and working on app

* menu can be horizontal

* added gallery

* refactor

* small fixes

* RGB example

* inspect re-worked

* refactor

* bump

* reverted to master progress bar

* tests passing

* tests passing

* refactoring controls

* no stdout in precomp (#191)

* no stdout in precomp

* ignore precompilation code in coverage

* working on controls

* debug mode and working controls

* small imrpvoements

* removed live internals from widgets

* all widgets play through app

* bump

* small fixes

* working on responsive app size

* working on resposive

* pager improvements

* tictactoe

* small improvements

* tests fix

* bump

* widget internals

* transitions inferred from layout

* wip

* all widgets work

* added help msg

* help msg

* bump

* finished re-factoring tree

* CI fix

* added test

* CI fix

* bump

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
Co-authored-by: Rémi Vezy <VEZY@users.noreply.github.com>
Co-authored-by: Federico Claudi <federicoclaudi@imac.mynetworksettings.com>
* fixed logs problems

* bump

* fixed layout in repr functionality

* fixed err msg not showing up in progress

* added option to expand stackatrace width

* CI fix

* CI fix

* CI fix

* CI fix

* CI fix

* CI fix

* CI fix

* working on docs

* bump
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #174 (6d9f48b) into master (82f1dbe) will decrease coverage by 7.65%.
The diff coverage is 68.16%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   94.94%   87.29%   -7.65%     
==========================================
  Files          38       48      +10     
  Lines        2473     2873     +400     
==========================================
+ Hits         2348     2508     +160     
- Misses        125      365     +240     
Impacted Files Coverage Δ
src/Live/keyboard_input.jl 0.00% <0.00%> (ø)
src/Term.jl 90.00% <ø> (ø)
src/_inspect.jl 22.72% <0.00%> (-72.93%) ⬇️
src/introspection.jl 29.31% <0.00%> (-70.69%) ⬇️
src/markdown.jl 92.23% <ø> (ø)
src/prompt.jl 73.58% <0.00%> (ø)
src/segments.jl 100.00% <ø> (ø)
src/Live/buttons.jl 13.51% <13.51%> (ø)
src/highlight.jl 90.32% <25.00%> (-9.68%) ⬇️
src/Live/app.jl 50.00% <50.00%> (ø)
... and 35 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FedeClaudi FedeClaudi marked this pull request as ready for review February 6, 2023 00:10
@FedeClaudi FedeClaudi merged commit c142c5c into master Feb 6, 2023
@FedeClaudi FedeClaudi deleted the 2.0 branch April 26, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant