Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added GitHub Issue Forms as proposed in #844 #848

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

tobirohrer
Copy link
Contributor

@tobirohrer tobirohrer commented Oct 31, 2022

Description

Change from GitHub templates to GitHub issue forms. See GitHub Issue Forms for more details on GitHub Issue Forms.

The main argument for using GitHub Issue Forms is that it is possible to encourage contributors to use the structure given. Additionally, the input is done by web form fields, which look nicer 😊

Fixes #844

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Screenshots

Before:
image

After:
image

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@WillDudley WillDudley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!

@WillDudley WillDudley merged commit 41ae114 into Farama-Foundation:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Use GitHub Issue Forms
2 participants