Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

butterfly.md: added check for termination in knight_archers #1080

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

GiovanniGrotto
Copy link
Contributor

Description

I added a termination/truncation in butterfly.md knight_archers piece of code so it won't give a non-None action to dead agent causing ValueError

Fixes # (issue), Depends on # (pull request)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower
Copy link
Contributor

Can you add the fix to the env itself in this pr too? So when you remove the clock you add it back in elsewhere

@elliottower elliottower merged commit f0c94c6 into Farama-Foundation:master Aug 30, 2023
@GiovanniGrotto GiovanniGrotto deleted the doc_fix branch September 2, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants