Env creation tutorial 2 : grid size inconsistent #1036
Conversation
There were two mistakes - The grid is 8x8, not 7x7 : the guard starts at position (7,7) - The type was integers and it conflicts with the characters we assign in the function
|
For info, I want to have this PR validated before doing a C/C for tutorial 3 of env creation |
BertrandDecoster
changed the title
| @@ -104,7 +104,7 @@ def step(self, actions): | |||
| return observations, rewards, terminations, truncations, infos | |||
|
|
|||
| def render(self): | |||
| grid = np.zeros((7, 7)) | |||
| grid = np.full((7,7), ' ', dtype='U1') | |||
There was a problem hiding this comment.
What does the second argument to np.full do here? And I googled around to see what exactly dtype U1 is but I'm confused about how this site says https://note.nkmk.me/en/python-numpy-dtype-astype/ the dtype should be <U1?
There was a problem hiding this comment.
The render space doesn't have to be the same as the observation space to be fair, but I can see how if we're overriding an array of integers with characters as the input that's a little sloppy. Granted, numpy lets you do that so it's like, ultimately it doesn't matter and is arguably cleaner code, but not as strictly correct. Could do it as a list of lists of size 49 or some other data type as well, but this is probably cleaner
There was a problem hiding this comment.
Are you sure it doesn't matter? It doesn't seem to want to write down a char in a array of floats
There was a problem hiding this comment.
But you're right that numpy does type inference and selects an appropriate type, so there's no need to manually specify that it's Unicode, I can remove U1
There was a problem hiding this comment.
Ah I see, thanks for testing it out. Looks good just doing full with a space character
|
If you can fix pre commit I’d be happy to merge |
There were two mistakes
render()was integers and it conflicts with the characters we assign in the functionDescription
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue), Depends on # (pull request)
Type of change
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)pytest -vand no errors are present.pytest -vhas generated that are related to my code to the best of my knowledge.Most of those at not relevant, it's a doc change