Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer multiple maps support #66

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Transfer multiple maps support #66

merged 3 commits into from
Mar 4, 2022

Conversation

xluox
Copy link
Contributor

@xluox xluox commented Mar 3, 2022

I have made a new branch and transferred some changes from the old PO multiple map branch into the new branch.

@xluox xluox requested a review from vwxyzjn March 3, 2022 03:09
vwxyzjn
vwxyzjn requested changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@vwxyzjn vwxyzjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please see my comments. Would you mind also changing the pointer of the microrts repository? Right now you are pointing at an older version, which is the reason we see the following in the Files Changed tab.

image

experiments/league.py Outdated Show resolved Hide resolved
experiments/ppo_gridnet.py Outdated Show resolved Hide resolved
@xluox
Copy link
Contributor Author

xluox commented Mar 4, 2022

@vwxyzjn How to change the pointer of microrts?

@xluox
Update the league evaluation
741b7fc 
Delete changes made to ppo_gridnet and focus on supporting multiple maps in evaluation.
@xluox xluox linked an issue Mar 4, 2022 that may be closed by this pull request
Support multiple maps during league evaluation. #68
Closed
@xluox
Copy link
Contributor Author

xluox commented Mar 4, 2022

@vwxyzjn I want to focus on supporting multiple maps for evaluation first.

@xluox xluox requested a review from vwxyzjn March 4, 2022 01:27
@vwxyzjn
Copy link
Collaborator

vwxyzjn commented Mar 4, 2022

@vwxyzjn How to change the pointer of microrts?

cd gym_microrts/microrts
git checkout bf077a203e10329e0b23f01665d02eb5cfdc77fe
cd ..
cd ..
bash build.sh
# add the repository change to git.

@vwxyzjn I want to focus on supporting multiple maps for evaluation first.

This sounds good.

@xluox xluox marked this pull request as ready for review March 4, 2022 15:47
vwxyzjn
vwxyzjn approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@vwxyzjn vwxyzjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vwxyzjn vwxyzjn merged commit cef85b7 into master Mar 4, 2022
@vwxyzjn vwxyzjn deleted the Support-multiple-maps-intergration branch March 11, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vwxyzjn vwxyzjn vwxyzjn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple maps during league evaluation.
2 participants
@xluox @vwxyzjn