Forbid unlocking accounts with enabled external RPC #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadv
reviewed
Jul 8, 2022
| @@ -269,7 +270,7 @@ func newService(config Config, store *Store, blockProc BlockProc, engine lachesi | |||
| } | |||
|
|
|||
| // create API backend | |||
| svc.EthAPI = &EthAPIBackend{config.ExtRPCEnabled, svc, stateReader, txSigner, config.AllowUnprotectedTxs} | |||
| svc.EthAPI = &EthAPIBackend{false, svc, stateReader, txSigner, config.AllowUnprotectedTxs} | |||
There was a problem hiding this comment.
it seems that we intend to init this with true? otherwise, it still work like before
Suggested change
| svc.EthAPI = &EthAPIBackend{false, svc, stateReader, txSigner, config.AllowUnprotectedTxs} | |
| svc.EthAPI = &EthAPIBackend{true, svc, stateReader, txSigner, config.AllowUnprotectedTxs} |
There was a problem hiding this comment.
It's initialized by SetExtRPCEnabled later
rus-alex
approved these changes
Jul 8, 2022
| @@ -39,6 +39,11 @@ type EthAPIBackend struct { | |||
| allowUnprotectedTxs bool | |||
| } | |||
|
|
|||
| // SetExtRPCEnabled updates extRPCEnabled | |||
| func (b *EthAPIBackend) SetExtRPCEnabled(v bool) { | |||
There was a problem hiding this comment.
Setter is not needed, just assign it directly.
There was a problem hiding this comment.
I just wanted to highlight that this variable may be initialized after object creation
hadv
approved these changes
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--allow-insecure-unlockargument is added