-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved model classes in model package #313
Conversation
The change makes sense to me. I think it is a much better separation than what we used to have before: the main package and the Can you also move model-related test classes to the We should try to avoid circular dependencies between packages. Can we make You will also need to resolve the merge conflict. |
Hi Tomas, |
import java.util.Collection; | ||
import java.util.List; | ||
|
||
public interface SuperCodec<S, T extends S> extends Codec<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this need to become public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its used in StyleClassedTextArea
:
SuperCodec.upCast(SuperCodec.collectionListCodec(Codec.STRING_CODEC)),
SuperCodec.upCast(SuperCodec.collectionListCodec(Codec.STRING_CODEC))
Other than the |
Make SuperCodec package private again.
👍 |
This commit moves the model related classes into a separate "model" package. Meanwhile, there are plenty of classes in the "org.fxmisc.richtext" package, both UI related (with a strong dependency on JavaFX Node classes to create the scene nodes) and model related. Separating out the model classes would definitely help to understand the overall structure of the editor, specifically when getting started.
The drawback might be that some classes and methods had to be made public rather than package scoped, but I think this is reasonable.
Any comments are welcome ...