Improve CUDAEnsemble's error reporting. #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robadob
force-pushed
the
cuda_ensemble_errors
branch
from
c7b693e to
69972c0
Compare
Robadob
force-pushed
the
cuda_ensemble_errors
branch
2 times, most recently
from
26a776d to
d13673f
Compare
Robadob
force-pushed
the
cuda_ensemble_errors
branch
from
d13673f to
bd7b2db
Compare
ptheywood
requested changes
May 17, 2022
There was a problem hiding this comment.
Could do with test(s) for the changes to CUDAEnsemble::checkArgs, verifying all documented accepted values work (and set the correct error level) plus atleast one test of bad input (bad integer, bad string, missing value).
Short and long forms would also be good.
Otherwise, the changes look good though I've not compiled or ran the code
ptheywood
reviewed
May 17, 2022
That's reasonable, didn't think of that. Will do. Edit: Useful too, arg parsing was bugged. |
With 4 additional tests that the 3 levels of error reporting, and related argument parsing.
Robadob
force-pushed
the
cuda_ensemble_errors
branch
from
bd7b2db to
14df52f
Compare
ptheywood
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added 3 tests to
TestCUDAEnsemblesuite, one for each error level, to confirm it works.Docs repo PR needs merging at same time: FLAMEGPU/FLAMEGPU2-docs#85