CMake: Escape user-provided regex patterns. #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptheywood
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Fixes paths including ++ with linting enabled under linux 👍
Might cause me some conflicts with #1062, but that's a problem for future me (and I just need to make sure I don't undo this fix when that gets merged, hence I'm tagging that PR here)
Robadob
added a commit
that referenced
this pull request
Jul 18, 2023
Must have got broken when tidying up #1085 and missed in review.
Robadob
added a commit
that referenced
this pull request
Jul 27, 2023
Must have got broken when tidying up #1085 and missed in review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1071 (See issue for fix commentary)