-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake CUDA flags for MinSizeRel RelWithDebInfo #798
Comments
Includes a couple of other very minor CMake tweaks Closes #798
By default, CMake's CUDA integration sets:
So this resolves the
Seatbelts being always on for debug only makes sense, otherwise it is up to the user already (and defaults to enabled), which seems sane to me. I'll chuck a quick PR in enabling |
Includes a couple of other very minor CMake tweaks Unfortunately cannot use the multi-argument form of $<CONFIG: as this requires CMake >= 3.19 Closes #798
Includes a couple of other very minor CMake tweaks Unfortunately cannot use the multi-argument form of $<CONFIG: as this requires CMake >= 3.19 Closes #798
We may wish to adjust our CMake to set certain values for
MinSizeRel
andRelWithDebInfo
builds which are currently only set for Debug or Release builds as appropriate.I.e. the default value of SEATBELTS, use of
-lineinfo
and-G
etc.This is unlikely to effect most users (who will likely use Debug or Release exclusively) but would be nice to improve (at least
RelWithDebInfo
).We probably always want to set
-lineinfo
, unless-G
is set.It's less clear when
(_)DEBUG
/(_)NDEBUG
should be set which might need some thought / reading.The easiest way to find current non-default cmake config specific options is to search for
CONFIG:
. Due to IDE style tools such as Visual Studio, we should only use generator expressions for this type of thing rather than usingCMAKE_BUILD_TYPE
anywhere.The text was updated successfully, but these errors were encountered: