Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CUDA 10.x and C++14 support #89

Merged
merged 2 commits into from
May 18, 2022
Merged

Remove CUDA 10.x and C++14 support #89

merged 2 commits into from
May 18, 2022

Conversation

ptheywood
Copy link
Member

@ptheywood ptheywood commented May 13, 2022

  • Blocks CUDA 10.x
  • Always builds as c++17, implicitly increasing minimum host compiler versions
  • Use std::filesystem all the time

This matches with a corresponding FLAMEGPU/FLAMEGPU2 pull request, although this is not required for the main repository to still function as intended (infact, this should be merged after or as part of that PR being merged, though we do not have vis + CUDA 10 CI anyway iirc)

Tested locally under linux via VISUALISATION_ROOT

Copy link
Member

@Robadob Robadob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptheywood
Copy link
Member Author

Apparently I pushed without commiting that change...

 M src/CMakeLists.txt
 M src/flamegpu/visualiser/shader/ShaderCore.cpp
 M src/flamegpu/visualiser/texture/Texture2D.cpp
 M src/flamegpu/visualiser/util/Resources.cpp

Pushed now.

@ptheywood ptheywood requested a review from Robadob May 16, 2022 10:54
Copy link
Member

@Robadob Robadob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@ptheywood ptheywood merged commit 1077d64 into master May 18, 2022
@ptheywood ptheywood deleted the drop-cuda-10.x branch May 18, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants