Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch testing url #373

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Patch testing url #373

merged 3 commits into from
Apr 19, 2023

Conversation

hategan
Copy link
Collaborator

@hategan hategan commented Apr 11, 2023

This changes the test upload url in testing.conf to testing.psij.io (which is now live).

It also updates ci_runner.py to patch testing.conf on systems where the tests are already set up.

And ci_runner.py now has a slightly nicer way of applying such patches.

@hategan hategan requested review from mtitov and andre-merzky April 11, 2023 17:11
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #373 (dab10ef) into main (3a15a55) will decrease coverage by 0.53%.
The diff coverage is 31.48%.

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   69.72%   69.20%   -0.53%     
==========================================
  Files          74       74              
  Lines        3168     3208      +40     
==========================================
+ Hits         2209     2220      +11     
- Misses        959      988      +29     
Impacted Files Coverage Δ
tests/ci_runner.py 21.71% <31.48%> (+1.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I just wonder if using the patch utility would make this simpler?

@hategan
Copy link
Collaborator Author

hategan commented Apr 19, 2023

I just wonder if using the patch utility would make this simpler?

Possibly, and we could do that. But probably not that much simpler.

@hategan hategan merged commit c143685 into main Apr 19, 2023
@hategan hategan deleted the patch_testing_url branch April 19, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants