Fix 404 page (missing tabs property was making it render funny). #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added code to detect if the 404 is on a documentation page. The version switcher in the documentation attempts to preserve the path (so that if you are looking at, say, JobExecutor in a version, you'd also potentially be looking at JobExecutor after the switch). However, there is no guarantee that the docs structure is the same in the two versions, so you may land on a page that's not there. The code looks at whether you are hitting a 404 on a docs page and offers a link to the main docs page for that version. Also, a minor fix in `getCurrentVersion`
Codecov Report
@@ Coverage Diff @@
## main #371 +/- ##
==========================================
+ Coverage 69.72% 69.79% +0.06%
==========================================
Files 74 74
Lines 3168 3168
==========================================
+ Hits 2209 2211 +2
+ Misses 959 957 -2 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added code to detect if the 404 is on a documentation page. The version switcher in the documentation attempts to preserve the path (so that if you are looking at, say, JobExecutor in a version, you'd also potentially be looking at JobExecutor after the switch). However, there is no guarantee that the docs structure is the same in the two versions, so you may land on a page that's not there. The code looks at whether you are hitting a 404 on a docs page and offers a link to the main docs page for that version.
Also, a minor fix in
getCurrentVersion