Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option to disable Relic, Charm & Potion stacking #278

Closed
NANI-ship-it opened this issue Jan 15, 2020 · 2 comments · Fixed by #465
Closed

Add new option to disable Relic, Charm & Potion stacking #278

NANI-ship-it opened this issue Jan 15, 2020 · 2 comments · Fixed by #465

Comments

@NANI-ship-it
Copy link

Please consider adding an option to disable Relic and Charm stacking and completion, and Potion stacking, for a "purist" way of using TQVaultAE only for muling. Currently it's easy to accidentally stack Relics, Charms and Potions when the intention is to just move them around.

Especially the Relic - and probably Charm too, didn't test that - completion bothers me slightly, because the Completion Bonus works in a bit different way in-game. More info below.

P.S. Also, I did a quick test on how Relic Seed affects the Completion Bonus. I had 3 pieces (piece = 1/3rd of a Relic) of a Relic each with a different Seed, let's call this a set. Then I Duplicated the set multiple times, so that I could repeat the combining of the Relic pieces, doing it always in the same order, e.g. Set 1 = Seed 1 -> 2 -> 3; Set 2 = Seed 1 -> 2 -> 3; etc.

Combining the Relics this way in TQVaultAE seems to randomize the completion bonus according to the Completion Bonus weightings, which seems logical and how it should work. But, in-game, the Completion Bonus was always the same for each set, because the Seeds of the pieces were identical in each set.

Of course in practice that doesn't really make much of a difference, because the Relics' Seeds are going to be random anyway, but the bottom line is that there is a difference in how the Completion bonuses are handled in TQVaultAE compared to the game.

Anyway, these are minor things and the tool itself is great. Thanks to all involved in creating it!

@EtienneLamoureux EtienneLamoureux changed the title Add an option to disable Relic and Charm stacking and completion, and Potion stacking Add new option to disable Relic, Charm & Potion stacking Jan 17, 2020
@EtienneLamoureux
Copy link
Owner

Thanks for the contribution.
Also interesting experiment you ran. Unfortunately, anything that has to do with seeds is a black-box on our end, so there will be no foreseeable change on that front.

hguy added a commit to hguy/TQVaultAE that referenced this issue Aug 17, 2022
@hguy
Copy link
Collaborator

hguy commented Aug 17, 2022

@NANI-ship-it this feature is coming soon.

EtienneLamoureux pushed a commit that referenced this issue Oct 29, 2022
* Fix #278 disable Relic, Charm & Potion stacking
* Add "Having Relic", "Having Charm" into Highlight
* Fix #442 Display the effects of EE potions
* Fix #287 Error when no save found
* Fix #467 by making path editing much clearer
* Fix #471 - Add Highlight "Set Item" filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants