Fix /nick off breaking with changecolor permissions #4876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why I didn't think of this in the first place 🤔
JRoy
added
bug: confirmed
JRoy
approved these changes
Mar 31, 2022
|
Not a race condition but thanks for the catch none the less! |
JRoy
changed the title
JRoy
changed the title
PureGero
pushed a commit
to CritterzNFT/Essentials
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #4822 .
Details
Proposed fix:
The bug stems from a race condition between formatNickname method and the updatePlayer method.
My fix adds an additional check to the only color changes if statement to make sure its not the off argument.
Environments tested:
OS: Windows 11
Java version: 17.0.1
Demonstration:
Before Fix: (Tested with EssentialsX 2.19.4 and 2.20.0-dev+4-4bd1b3c)
After Fix: (Tested by using the compiled version with this commit)
