Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preemptive setting of owner metadata on to trade signs #4835

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Fix preemptive setting of owner metadata on to trade signs #4835

merged 1 commit into from
Mar 8, 2022

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Mar 8, 2022 •
edited by mdcfe
Loading

Fixes #4836.

JRoy code

image

@JRoy JRoy added bug: confirmed Confirmed bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Mar 8, 2022
@JRoy JRoy added this to the 2.19.4 milestone Mar 8, 2022
@mdcfe mdcfe self-requested a review March 8, 2022 12:38
mdcfe
mdcfe approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@mdcfe mdcfe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some consistency issues UUIDs aren't always set when a sign is placed nor are they always converted on first use after an upgrade. This does, however, fix the conversion problems in #4836.

@mdcfe mdcfe merged commit 997fb18 into EssentialsX:2.x Mar 8, 2022
@mdcfe mdcfe deleted the fix/jroy-code branch March 8, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdcfe mdcfe mdcfe approved these changes

Assignees
No one assigned
Labels
bug: confirmed Confirmed bugs in EssentialsX. module: main Issues or PRs for the main Essentials module
Projects
None yet
Milestone
2.19.4
Development

Successfully merging this pull request may close these issues.

Trade signs change owner if used by another player for the first time after upgrading EssentialsX
2 participants
@JRoy @mdcfe