-
-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add per-command command cooldown bypass permissions #4759
Merged
mdcfe
merged 15 commits into
EssentialsX:2.x
from
JRoy:feat/per-command-cooldown-bypass
Feb 13, 2023
Merged
Add per-command command cooldown bypass permissions #4759
mdcfe
merged 15 commits into
EssentialsX:2.x
from
JRoy:feat/per-command-cooldown-bypass
Feb 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
added
type: enhancement
Features and feature requests.
module: main
Issues or PRs for the main Essentials module
labels
Jan 16, 2022
pop4959
previously requested changes
Feb 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick but otherwise looks good
Essentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java
Outdated
Show resolved
Hide resolved
…yerListener.java Co-authored-by: pop4959 <pop4959@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been testing this for months, working fine without issues.
mdcfe
approved these changes
Feb 13, 2023
This was referenced Feb 14, 2023
Chris6ix
added a commit
to Chris6ix/essinfo.xeya.me
that referenced
this pull request
Feb 14, 2023
Adds the new permission from EssentialsX/Essentials#4759 Removes the separate cooldown bypass permissions for `/heal`, `/feed`, `/tpa` and `/back` as they are now redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: main
Issues or PRs for the main Essentials module
type: enhancement
Features and feature requests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the permission
essentials.commandcooldowns.bypass.<command name>
to bypass the cooldown for a specific command.Closes #4747