Add playtime command #4562
Merged
Add playtime command #4562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
requested changes
Oct 5, 2021
Essentials/src/main/java/com/earth2me/essentials/commands/Commandplaytime.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/commands/Commandplaytime.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/commands/Commandplaytime.java
Outdated
Show resolved
Hide resolved
JRoy
added
module: main
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
JRoy
requested changes
Oct 5, 2021
JRoy
reviewed
Oct 5, 2021
- Made it actually compile (oops sorry) - Handle permissions correctly - Put new messages in the right place in message.properties
JRoy
requested changes
Oct 6, 2021
Essentials/src/main/java/com/earth2me/essentials/commands/Commandplaytime.java
Outdated
Show resolved
Hide resolved
JRoy
reviewed
Oct 6, 2021
Essentials/src/main/java/com/earth2me/essentials/commands/Commandplaytime.java
Outdated
Show resolved
Hide resolved
JRoy
reviewed
Oct 6, 2021
Essentials/src/main/java/com/earth2me/essentials/commands/Commandplaytime.java
Outdated
Show resolved
Hide resolved
JRoy
approved these changes
Oct 6, 2021
|
@MisterMelDev, would it be possible to add offline playtime support? This would be insanely useful. |
The way I implemented this, it currently wouldn't be possible. I'm using the built-in Bukkit statistics system, which also contains a statistic for playtime, but this can only be retrieved when the player is online. The plugin would have to store the playtime in the player data or something. I'm a bit busy currently, but maybe someone else could make a PR for that? |
Greetings! Just in case if still interested in offline data, there are a few implementation like the following wonderful one for a reference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR closes #3827.
Details
Proposed feature:
Allow players to view their own or another player's playtime.
Environments tested:
OS: Windows 10
Java version:
java version "16.0.1" 2021-04-20Demonstration: