Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to local chat #4535

Merged
merged 6 commits into from
Feb 14, 2022
Merged

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Sep 17, 2021

Tracking ideas from #4509

  • Config option for default shout state (Should players default to local or shout mode)
    • chat:
        ...
        # Whether players should be placed into shout mode by default.
        shout-default: false
  • Persist shouting state between restarts (in userdata) (add config option for this)
    • chat:
        ...
        # Whether a player's shout mode should persist restarts.
        persist-shout: false
  • Config option for question chat
    • chat:
        ...
        # Whether chat questions should be enabled or not.
        question-enabled: true
  • Permission for sending to local chat (like global and question has)
    • essentials.chat.local defaults to true
  • Permissions for receiving chat channels
    • Adds the following permissions which default to true: essentials.chat.receive.local, essentials.chat.receive.shout, and essentials.chat.receive.question.
  • Improve local chat prefix (color, spacing)
  • Using the shout prefix (! by default) while toggle shout is enabled will now send a message in local chat.

@JRoy JRoy added type: enhancement Features and feature requests. module: chat Issues or PRs for the EssentialsChat module labels Sep 17, 2021
@JRoy JRoy marked this pull request as ready for review September 29, 2021 02:04
@JRoy JRoy force-pushed the feat/chat-improvements branch 2 times, most recently from 3ac5966 to 7e54d22 Compare September 30, 2021 01:09
@JRoy JRoy enabled auto-merge (rebase) September 30, 2021 01:10
@JRoy JRoy force-pushed the feat/chat-improvements branch 2 times, most recently from 813c8cb to 296d42a Compare October 13, 2021 01:57
pop4959
pop4959 previously approved these changes Oct 28, 2021
@JRoy JRoy force-pushed the feat/chat-improvements branch from 296d42a to 3f09baa Compare November 6, 2021 20:57
@JRoy JRoy force-pushed the feat/chat-improvements branch from 3f09baa to 9ae9f4f Compare November 24, 2021 16:18
@JRoy JRoy force-pushed the feat/chat-improvements branch from 9ae9f4f to a8f2039 Compare December 16, 2021 01:10
@JRoy JRoy force-pushed the feat/chat-improvements branch from a8f2039 to 615865d Compare December 26, 2021 15:39
mdcfe
mdcfe previously requested changes Dec 29, 2021
Essentials/src/main/resources/messages.properties Outdated Show resolved Hide resolved
Essentials/src/main/resources/config.yml Show resolved Hide resolved
@mdcfe mdcfe added this to the 2.20.0 milestone Dec 29, 2021
@JRoy JRoy force-pushed the feat/chat-improvements branch from 615865d to 4d1a64b Compare December 29, 2021 14:56
@JRoy JRoy force-pushed the feat/chat-improvements branch from 4d1a64b to b592b7c Compare February 1, 2022 22:35
@JRoy JRoy requested a review from mdcfe February 14, 2022 03:41
@JRoy JRoy force-pushed the feat/chat-improvements branch from b592b7c to f26547e Compare February 14, 2022 03:41
@JRoy JRoy merged commit cbb0128 into EssentialsX:2.x Feb 14, 2022
@JRoy JRoy deleted the feat/chat-improvements branch February 22, 2022 13:35
@mdcfe mdcfe modified the milestones: 2.20.0, 2.19.3 Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: chat Issues or PRs for the EssentialsChat module type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants