Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord Module Fixups #4293

Merged
merged 4 commits into from
Jul 1, 2021
Merged

Discord Module Fixups #4293

merged 4 commits into from
Jul 1, 2021

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Jul 1, 2021 •
edited
Loading

Minor fixups/feedback from launch of discord module.

Changes:

  • Added server-start message type
  • Added server-stop message type
  • Allow uppercase variable names
  • Sanitize format messages to prevent errors
  • Fixed executing vanilla commands in /execute command

@JRoy JRoy added the module: discord Issues or PRs for the EssentialsDiscord module label Jul 1, 2021
@JRoy JRoy added this to the 2.19.0 milestone Jul 1, 2021
@JRoy JRoy added type: bugfix PRs that fix bugs in EssentialsX. type: enhancement Features and feature requests. labels Jul 1, 2021
@JRoy JRoy marked this pull request as ready for review July 1, 2021 19:02
@JRoy JRoy force-pushed the fixup/discord-addon branch from 5300145 to acc9b26 Compare July 1, 2021 19:14
@JRoy JRoy enabled auto-merge (rebase) July 1, 2021 19:17
@JRoy JRoy force-pushed the fixup/discord-addon branch from acc9b26 to 05b4218 Compare July 1, 2021 19:19
@JRoy JRoy force-pushed the fixup/discord-addon branch from 05b4218 to cf10704 Compare July 1, 2021 19:23
@JRoy JRoy force-pushed the fixup/discord-addon branch from cf10704 to 096025a Compare July 1, 2021 19:24
@JRoy JRoy requested a review from mdcfe July 1, 2021 19:41
@JRoy JRoy merged commit a552891 into 2.x Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdcfe mdcfe mdcfe approved these changes

Assignees
No one assigned
Labels
module: discord Issues or PRs for the EssentialsDiscord module type: bugfix PRs that fix bugs in EssentialsX. type: enhancement Features and feature requests.
Projects
None yet
Milestone
2.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JRoy @mdcfe