Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various trade sign issues #4056

Merged
merged 6 commits into from
Apr 14, 2021
Merged

Fix various trade sign issues #4056

merged 6 commits into from
Apr 14, 2021

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Mar 13, 2021 •
edited
Loading

Fixes #3384

  • Line text length is now checked before each Sign#setLine check

Fixes #4014

  • The total amount of an itemstack inside a given players inventory is now used rather than just the amount of the held itemstack. Fixes restocking trades over the max stack size.

@JRoy JRoy added the type: bugfix PRs that fix bugs in EssentialsX. label Mar 13, 2021
@JRoy JRoy added this to the 2.19.0 milestone Mar 13, 2021
@JRoy JRoy requested a review from mdcfe March 29, 2021 18:04
@JRoy JRoy changed the title Fix various issues with trade sign line lengths Fix various trade sign issues Apr 14, 2021
@JRoy JRoy merged commit 5171215 into EssentialsX:2.x Apr 14, 2021
@JRoy JRoy deleted the trade-signs-are-my-passion branch April 14, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdcfe mdcfe mdcfe approved these changes

Assignees
No one assigned
Labels
type: bugfix PRs that fix bugs in EssentialsX.
Projects
None yet
Milestone
2.19.0
Development

Successfully merging this pull request may close these issues.

Unable to restock trade signs if you're trying to sell more than 64 Trade Signs: Duplication Glitch
2 participants
@JRoy @mdcfe