Use username instead of nickname in console /sell messages #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
approved these changes
Oct 3, 2020
mdcfe
approved these changes
Oct 5, 2020
Chew
pushed a commit
to Chew/Essentials
that referenced
this pull request
Nov 25, 2020
…sX#3693) Closes EssentialsX#3662 This PR changes the default placeholder `{0}` to username. Display name can still be used with `{5}`. Before change: messages.properties `itemSoldConsole=\u00a7e{0} \u00a7asold\u00a7e {1}\u00a7a for \u00a7e{2} \u00a7a({3} items at {4} each).` console `[Essentials] ~test sold dirt for $64 (64 items at $1 each).` After change: messages.properties `itemSoldConsole=\u00a7e{0} \u00a7asold\u00a7e {1}\u00a7a for \u00a7e{2} \u00a7a({3} items at {4} each).` console `[Essentials] pop4959 sold dirt for $64 (64 items at $1 each).` messages.properties `itemSoldConsole=\u00a7e{5} \u00a7asold\u00a7e {1}\u00a7a for \u00a7e{2} \u00a7a({3} items at {4} each).` console `[Essentials] ~test sold dirt for $64 (64 items at $1 each).`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3662
This PR changes the default placeholder
{0}to username. Display name can still be used with{5}.Before change:
messages.properties
itemSoldConsole=\u00a7e{0} \u00a7asold\u00a7e {1}\u00a7a for \u00a7e{2} \u00a7a({3} items at {4} each).console
[Essentials] ~test sold dirt for $64 (64 items at $1 each).After change:
messages.properties
itemSoldConsole=\u00a7e{0} \u00a7asold\u00a7e {1}\u00a7a for \u00a7e{2} \u00a7a({3} items at {4} each).console
[Essentials] pop4959 sold dirt for $64 (64 items at $1 each).messages.properties
itemSoldConsole=\u00a7e{5} \u00a7asold\u00a7e {1}\u00a7a for \u00a7e{2} \u00a7a({3} items at {4} each).console
[Essentials] ~test sold dirt for $64 (64 items at $1 each).