Make HelpInput use the known command map #3675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Citymonstret
force-pushed
the
help-input-known-commands
branch
from
840a519 to
c914554
Compare
JRoy
previously approved these changes
Sep 15, 2020
jpenilla
previously approved these changes
Sep 16, 2020
pop4959
previously approved these changes
Sep 16, 2020
mdcfe
added
the
status: needs manual rebase
mdcfe
previously approved these changes
Oct 19, 2020
JRoy
previously approved these changes
Oct 19, 2020
mdcfe
reviewed
Oct 19, 2020
mdcfe
previously approved these changes
Oct 19, 2020
JRoy
previously approved these changes
Oct 19, 2020
mdcfe
reviewed
Oct 19, 2020
providers/NMSReflectionProvider/src/net/ess3/nms/refl/providers/ReflKnownCommandsProvider.java
Outdated
Show resolved
Hide resolved
providers/NMSReflectionProvider/src/net/ess3/nms/refl/providers/ReflKnownCommandsProvider.java
Outdated
Show resolved
Hide resolved
mdcfe
reviewed
Oct 19, 2020
providers/NMSReflectionProvider/src/net/ess3/nms/refl/providers/ReflKnownCommandsProvider.java
Show resolved
Hide resolved
…. Thanks to @jmanpenilla for pointing this out.
mdcfe
force-pushed
the
help-input-known-commands
branch
from
8a57eca to
d9001b3
Compare
mdcfe
approved these changes
Oct 19, 2020
mdcfe
removed
the
status: needs manual rebase
mdcfe
changed the title
Chew
pushed a commit
to Chew/Essentials
that referenced
this pull request
Nov 25, 2020
Co-authored-by: MD <1917406+md678685@users.noreply.github.com> This PR makes HelpInput use knownCommands in the command map, rather than relying on plugin descriptions. This means that commands that have been registered programmatically (or impromptu) will be recognized and displayed in the help menu. The ugly reflection is due to Spigot not exposing the command map getter. This has been tested on Spigot 1.8, 1.16.3 and Paper 1.16.3 with plugins that register commands directly to the command map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes HelpInput use knownCommands in the command map, rather than relying on plugin descriptions. This means that commands that have been registered programmatically (or impromptu) will be recognized and displayed in the help menu.
The ugly reflection is due to Spigot not exposing the command map getter. This has been tested on Spigot 1.8, 1.16.3 and Paper 1.16.3 with plugins that register commands directly to the command map.