Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

controllerAs and bindToController #123

Merged
merged 5 commits into from
Oct 12, 2015
Merged

controllerAs and bindToController #123

merged 5 commits into from
Oct 12, 2015

Conversation

tomwayson
Copy link
Member

Update map and layer directives to use controllerAs and bindToController instead of injecting $socpe into controllers.

resolves #109

@jwasilgeo
Copy link
Contributor

@tomwayson this looks really, really great!

Just in terms of minor housekeeping, I was looking over the inline comments and wondered if we should update them? I was struggling with thinking of the right terms to use where we previously made references to $scope in the changed files. As an aside, I like how the bindToController docs word it.

For example, in esriMap:

  • here; and other similar comments
  • here; change param names to the func, change the func name, etc?

PS: Or, no worries, and we can revisit if we want to when looking into documentation.

tomwayson added a commit that referenced this pull request Oct 12, 2015
controllerAs and bindToController
@tomwayson tomwayson merged commit 3542da3 into master Oct 12, 2015
@tomwayson
Copy link
Member Author

Thanks @jwasil, I will address the comments/function name as part of later refactoring, or as you say, we can do it when we get into the docs.

@jwasilgeo
Copy link
Contributor

👍 !

@tomwayson tomwayson deleted the bind-to-controller branch October 14, 2015 05:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor directives to use controllerAs (and bindToController?)
2 participants