Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance table #982

Merged
merged 10 commits into from
Sep 2, 2022
Merged

Enhance table #982

merged 10 commits into from
Sep 2, 2022

Conversation

notoraptor
Copy link
Collaborator

@notoraptor notoraptor commented Aug 3, 2022

Description

Hi @bouthilx , this is a PR with some enhancements for trials table

Changes

  • Use light gray for empty column headers
  • Allow to display all columns (useful if many columns are hidden) using a checkbox added in multiselect
  • Add drag-and-drop to change columns order
  • Display trial info in a dialog when clicking on trial row

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

@notoraptor
Copy link
Collaborator Author

TODO: Use instead a checkbox to "select all"

Put checkbox at top of columns in multiselect component

If all columns are selected, this checkbox should be selected

If any column is deselected, this checkbox should be deselected

@notoraptor
Copy link
Collaborator Author

Hi @bouthilx ! PR update, I added a checkbox to select all columns, instead of a button. Here is a screencast to show how it works.

Capture.d.ecran.video.de.2022-08-05.13.27.45.webm

@notoraptor
Copy link
Collaborator Author

Finally added drag-and-drop to change column order!

@notoraptor
Copy link
Collaborator Author

@bouthilx Updated!

  • Display trial info in a dialog when clicking on trial row

@notoraptor
Copy link
Collaborator Author

PS: We may need a demo to correctly review all changes ^^ !

@bouthilx bouthilx merged commit 9f11b7d into Epistimio:develop Sep 2, 2022
@notoraptor notoraptor deleted the enhance-table branch September 12, 2022 02:49
@bouthilx bouthilx added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label Dec 19, 2022
@notoraptor notoraptor mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants