Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework workon #684

Merged
merged 198 commits into from
Jan 28, 2022
Merged

Rework workon #684

merged 198 commits into from
Jan 28, 2022

Conversation

Delaunay
Copy link
Collaborator

@Delaunay Delaunay commented Oct 26, 2021 •
edited
Loading

[Fixes #613]

Description

Refactor how ExperimentClient schedule work.
Each workers now share a single HPO that dispatch work to them

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

Pierre Delaunay added 2 commits January 28, 2022 11:29
@Delaunay Delaunay merged commit 132d0ef into Epistimio:develop Jan 28, 2022
@Delaunay Delaunay deleted the parallel branch January 28, 2022 18:31
@bouthilx bouthilx added feature Introduces a new feature enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) and removed feature Introduces a new feature labels Jan 28, 2022
This was referenced Jan 28, 2022
Open
Open
lebrice pushed a commit to lebrice/orion that referenced this pull request Jan 31, 2022
@Delaunay @lebrice
Rework workon (Epistimio#684)
4f44d14
@bouthilx bouthilx mentioned this pull request Feb 11, 2022
Merged
lebrice pushed a commit to lebrice/orion that referenced this pull request Jun 27, 2022
@Delaunay @lebrice
Rework workon (Epistimio#684)
fdc5011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change workon to work on multiple trials locally instead of parallelizing sequential loops.
2 participants
@Delaunay @bouthilx