Add enable option for EVC, with default = false #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouthilx
added
the
enhancement
bouthilx
force-pushed
the
feature/optional_evc
branch
from
b716612 to
42704c8
Compare
The tests for the different EVC options were all inter-dependent. This commit makes them independent, all starting from the same DB state using the same command. This makes it much easier to make modifications in these tests without affecting all following tests.
The EVC is a constant source of confusion for users. It should be disabled by default with warning messages when different versions of experiments are used. Users who wants using advanced features of the EVC would still be able to use it by enabling it. Making it false by default is a breaking change and may cause issues to user currently using the EVC. Based on discussion with users there does not seem to have much usage of the EVC so far so this breaking change should be relatively harmless. Avoiding further confusion by making it disabled by default is worth the breaking change.
Why: If the EVC is not enabled, the consumer should always ignore the code changes. It would not make sense to raise an error between 2 trials because user's script code changed while EVC is disabled. How: If EVC is disabled, force ignore_code_changes to True in Consumer.
bouthilx
force-pushed
the
feature/optional_evc
branch
from
e4fa822 to
bb4e2b6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixes #547]
The EVC is a constant source of confusion for users. It should be
disabled by default with warning messages when different versions of
experiments are used. Users who wants using advanced features of the EVC
would still be able to use it by enabling it.
Making it false by default is a breaking change and may cause issues to
user currently using the EVC. Based on discussion with users there does
not seem to have much usage of the EVC so far so this breaking change
should be relatively harmless. Avoiding further confusion by making it
disabled by default is worth the breaking change.